-
Notifications
You must be signed in to change notification settings - Fork 734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][ESIMD]Implement slm_scatter accepting compile time properties #12591
Conversation
Looks like the tests are failing, I'll hold my review for now |
@fineg74 for such big code-changes please create 'Draft PR' first, then do a series of extra changes if necessary to get passes, then change draft to real PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I finished the 1st scan/review-pass. Please see my comments.
@sarnex - CI is green, please finish your code-review |
Will do, sorry |
/// void slm_scatter( | ||
/// OffsetSimdViewT byte_offsets, simd<T, N> vals, | ||
/// PropertyListT props = {}); // (slm-sc-4) | ||
/// Loads ("gathers") elements of the type 'T' from Shared Local Memory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment seems wrong, should be for scatter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address in follow-up PR for local accessors and scatter
This implements the unified memory API for slm_scatter with local accessors